[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1101102 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/patch.c svn/notify.c

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Tue, 10 May 2011 10:40:12 +0200

On 09.05.2011 19:58, Greg Stein wrote:
> On May 9, 2011 12:36 PM,<stefan2_at_apache.org> wrote:
>> Author: stefan2
>> Date: Mon May 9 16:36:28 2011
>> New Revision: 1101102
>> URL: http://svn.apache.org/viewvc?rev=1101102&view=rev
>> Log:
>> Fix conversion and signedness comparison warnings concerning the "fuzz"
>> factor. That value is non-negative, thus we can use the same type as for
>> the values that we combine or compare it with.
>> * subversion/include/svn_wc.h
>> (svn_wc_notify_t): make hunk_fuzz a "number of lines"
>> * subversion/libsvn_client/patch.c
>> (hunk_info_t, match_hunk, scan_for_match, get_hunk_info,
> apply_one_patch):
>> make all fuzz values a "number of lines"
>> * subversion/svn/notify.c
>> (notify): adapt format strings
> Isn't this kinda like using a time type to hold duration? :-P
It's at least close to it and I noticed that when I wrote the code ;)
Now that I think of it, the real solution would be introducing a
svn_linefuzz_t that is equivalent to svn_linenum_t. Please note
that svn_linediff_t would be wrong since the "fuzz" value cannot
be negative.

-- Stefan^2.
Received on 2011-05-10 10:40:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.