[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn info --recursive isn't reporting tree-conflict-only nodes

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Tue, 03 May 2011 16:19:19 +0100

On Tue, 2011-05-03 at 14:36 +0100, Philip Martin wrote:
> Julian Foad <julian.foad_at_wandisco.com> writes:
> > I found a bug in "svn info -R": it doesn't report a node that has a tree
> > conflict but otherwise is nonexistent, except if this node is the root
> > node of the requested target path.
> I think that's an actual-only node. See
> http://subversion.tigris.org/issues/show_bug.cgi?id=3779
> which says that we need to ensure that commands behave sensibly on
> actual-only nodes.


The 'info' code uses svn_wc__internal_walk_children(), and makes a
special case of checking for a tree conflict on the target node if that
walk function returns a NOT FOUND error. But 'info' doesn't check for
tree conflicts on other unvisited leaf nodes that may exist as
actual-only nodes.

One way or another, 'info' is going to have to walk a tree of nodes that
includes actual-only nodes. It could either do this itself or we could
have a walker function that does that. It's logically re-usable
functionality (even if 'info' is currently the only user) so we should
have some kind of walker function that does that. So I'll look at
adding this functionality into svn_wc__internal_walk_children().

- Julian
Received on 2011-05-03 17:19:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.