[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1099044 - /subversion/trunk/subversion/libsvn_ra_serf/commit.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 03 May 2011 15:16:33 +0100

Hyrum K Wright <hyrum_at_hyrumwright.org> writes:

>>   SVN_ERR(svn_io_open_unique_file3(&ctx->svndiff, NULL, NULL,
>> -                                   svn_io_file_del_on_pool_cleanup,
>> +                                   svn_io_file_del_on_close,
>>                                    ctx->pool, ctx->pool));
> This isn't part of your change, but we don't need to use ctx->pool for
> both result_pool and scratch_pool in the above function call. Using
> the function-provided pool as scratch_pool is sufficient.

Agreed; r1099066.

Received on 2011-05-03 16:17:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.