[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1098694 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/deprecated.c libsvn_wc/info.c svn/info-cmd.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 2 May 2011 15:30:01 -0400

On Mon, May 2, 2011 at 13:58, <hwright_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/include/svn_wc.h Mon May  2 17:58:05 2011
> @@ -3011,7 +3011,7 @@ typedef struct svn_wc_info_t
>   const char *copyfrom_url;
>   svn_revnum_t copyfrom_rev;
>   apr_time_t text_time;
> -  const char *checksum;
> +  svn_checksum_t *checksum;

const!

>...
> +      if (info2->wc_info->checksum
> +            && info2->wc_info->checksum->kind == svn_checksum_md5)
> +        info->checksum          = svn_checksum_to_cstring(
> +                                        info2->wc_info->checksum, pool);
> +      else
> +        info->checksum          = NULL;

I would note this means the checksum will be NULL for users of the old
API (since the new API returns SHA-1 checksums). This could be viewed
as a regression.

>...

Cheers,
-g
Received on 2011-05-02 21:30:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.