Re: svn commit: r1098649 - in /subversion/trunk/subversion/libsvn_client: client.h commit.c commit_util.c copy.c

On May 2, 2011 12:25 PM, <rhuijben_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_client/commit_util.c Mon May 2
16:25:30 2011
> @@ -1464,30 +1464,31 @@ svn_client__do_commit(const char *base_u
> apr_hash_t **md5_checksums,
> apr_hash_t **sha1_checksums,
> svn_client_ctx_t *ctx,
> - apr_pool_t *pool)
> + apr_pool_t *result_pool,
> + apr_pool_t *scratch_pool)
> {
> - apr_hash_t *file_mods = apr_hash_make(pool);
> - apr_hash_t *items_hash = apr_hash_make(pool);
> - apr_pool_t *iterpool = svn_pool_create(pool);
> + apr_hash_t *file_mods = apr_hash_make(scratch_pool);
> + apr_hash_t *items_hash = apr_hash_make(scratch_pool);
> + apr_pool_t *iter_pool = svn_pool_create(scratch_pool);

Why the iterpool rename? That breaks our conventions.

>...

Cheers,
-g
Received on 2011-05-02 20:56:27 CEST