Re: [PATCH] to help benchmark.py run on windows

Hi Alan,

Thanks for your patch.

Not too sure if you have been following the dev list discussions or not; but just in case you haven't been;
http://svn.haxx.se/dev/archive-2011-04/0243.shtml

Which would seem that Greg has been working on the same thing, making changes to the script to allow it to be portable across to a windows environment.
THat's not to say we're ignoring yours, it will get reviewed as soon as someone has time.

It was more an update for you in case you hadn't seen it already.

Gavin "Beau" Baumanis

On 18/04/2011, at 9:04 PM, Alan Wood wrote:

> Hi devs,
> I have just been looking at running the benchmarks and have got to the stage where I can
> run it on windows.
>
> This attached patch fixes three issues with the script:
> 1) use of file:// when I'm sure that file:/// is correct from previous discussions on this list
> 2) make sure no \ end up is repos url file://
> 3) at error handler to rmtree to handle the windows read-only files.
>
> I have removed the "which svn" command, not sure how to do this so it is only removed on
> windows as I'm not really a python person.
> I hope this is useful.
> I haven't provided a log message as I don't really think it can be applied without a bit of
> editing.
>
> Cheers
> Alan Wood
> <bench.patch>
Received on 2011-04-18 23:39:19 CEST