[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1094733 - /subversion/trunk/subversion/libsvn_wc/questions.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 18 Apr 2011 17:26:37 -0400

On Mon, Apr 18, 2011 at 16:35, <rhuijben_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/questions.c Mon Apr 18 20:35:14 2011
>...
> @@ -146,8 +156,22 @@ compare_and_verify(svn_boolean_t *modifi
>       return svn_error_return(svn_stream_close(pristine_stream));
>     }
>
> -  /* #### Can a file be smaller then its repository_normal form, or other
> -          optimizations? */
> +  if (need_translation
> +      && !special
> +      && !props_mod
> +      && (keywords == NULL)
> +      && (versioned_file_size < versioned_file_size))

That last line of the check certainly doesn't look correct :-P

>...
> @@ -287,8 +311,8 @@ svn_wc__internal_file_modified_p(svn_boo
>
>   if (! force_comparison)
>     {
> -      svn_filesize_t translated_size;
> -      apr_time_t last_mod_time;
> +      svn_filesize_t recorded_size;
> +      apr_time_t recorded_mod_time;

Nice.

>..

Cheers,
-g
Received on 2011-04-18 23:27:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.