On Apr 10, 2011 3:26 PM, "Bert Huijben" <bert_at_qqmail.nl> wrote:
>
>
>
> > -----Original Message-----
> > From: Greg Stein [mailto:gstein_at_gmail.com]
> > Sent: zondag 10 april 2011 7:26
> > To: dev_at_subversion.apache.org
> > Subject: Re: svn commit: r1090715 -
> > /subversion/trunk/subversion/libsvn_client/commit_util.c
> >
> > On Apr 9, 2011 7:54 PM, <rhuijben_at_apache.org> wrote:
> > >
> > > Author: rhuijben
> > > Date: Sat Apr 9 23:54:31 2011
> > > New Revision: 1090715
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1090715&view=rev
> > > Log:
> > > Two small optimizations in the commit handler: Assume absolute paths
are
> > > already absolute and only send fulltexts for local additions, instead
of
> > > for additions and copies.
> >
> > It is unclear that item->path is absolute. Ideally, renaming the field
> would
> > be best. At a minimum, add a comment here.
>
> This field in commit_item3_t and its older cousins *2_t and *_t are
> documented to be absolute paths since the early days (r841696, or r1622),
> when the log message editor api was introduced.
Ah. Thanks. IOW, it just hasn't caught up to our recent naming scheme. ...
Fair enuf!
Cheers,
-g
Received on 2011-04-11 12:07:23 CEST