[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1090715 - /subversion/trunk/subversion/libsvn_client/commit_util.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Sun, 10 Apr 2011 21:25:47 +0200

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: zondag 10 april 2011 7:26
> To: dev_at_subversion.apache.org
> Subject: Re: svn commit: r1090715 -
> /subversion/trunk/subversion/libsvn_client/commit_util.c
>
> On Apr 9, 2011 7:54 PM, <rhuijben_at_apache.org> wrote:
> >
> > Author: rhuijben
> > Date: Sat Apr 9 23:54:31 2011
> > New Revision: 1090715
> >
> > URL: http://svn.apache.org/viewvc?rev=1090715&view=rev
> > Log:
> > Two small optimizations in the commit handler: Assume absolute paths are
> > already absolute and only send fulltexts for local additions, instead of
> > for additions and copies.
>
> It is unclear that item->path is absolute. Ideally, renaming the field
would
> be best. At a minimum, add a comment here.

This field in commit_item3_t and its older cousins *2_t and *_t are
documented to be absolute paths since the early days (r841696, or r1622),
when the log message editor api was introduced.

        Bert
Received on 2011-04-10 21:26:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.