[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] unlock_cache called twice

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Sun, 03 Apr 2011 19:33:37 +0200

On 02.04.2011 07:52, Alan Wood wrote:
> Strange, it was a .txt file as an attachment but here it is inline too.
> Created the patch with Tsvn seems it got a mix of lin endings in it. I wonder if that didn't help.
> This time with all txt line endings.
In my private mailbox, the attachment was there
even for your initial post ...
>
> Hi All,
> Attached is a patch to fix a lock-up in the test_cache.exe on my windows system.
>
> [[[
> Fix the releasing of an already released mutex that caused test_cache to lock up when
> attempting to the aquire the mutex a second time.
>
> * subversion/libsvn_subr/cache-inprocess.c
> (inprocess_cache_get): remove second unlock of cache
> ]]]
>
>
> Alan
>
> Index: subversion/libsvn_subr/cache-inprocess.c
> ===================================================================
> --- subversion/libsvn_subr/cache-inprocess.c (revision 1087960)
> +++ subversion/libsvn_subr/cache-inprocess.c (working copy)
> @@ -248,7 +248,7 @@
> else
> *value_p = NULL;
>
> - return unlock_cache(cache, err);
> + return err;
> }
>
> /* Removes PAGE from the LRU list, removes all of its entries from
Thanks a lot! Committed as r1088341.

-- Stefan^2.

P.S.: Greetings from Stuttgart to New Zealand!
I really missed the summer sun this winter.
Received on 2011-04-03 19:34:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.