[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] unlock_cache called twice

From: Alan Wood <Alan.Wood_at_clear.net.nz>
Date: Sat, 02 Apr 2011 18:52:24 +1300

Strange, it was a .txt file as an attachment but here it is inline too.
Created the patch with Tsvn seems it got a mix of lin endings in it. I wonder if that didn't help.
This time with all txt line endings.

 Hi All,
  Attached is a patch to fix a lock-up in the test_cache.exe on my windows system.
  Fix the releasing of an already released mutex that caused test_cache to lock up when
 attempting to the aquire the mutex a second time.
 * subversion/libsvn_subr/cache-inprocess.c
   (inprocess_cache_get): remove second unlock of cache
Index: subversion/libsvn_subr/cache-inprocess.c
--- subversion/libsvn_subr/cache-inprocess.c (revision 1087960)
+++ subversion/libsvn_subr/cache-inprocess.c (working copy)
@@ -248,7 +248,7 @@
     *value_p = NULL;
- return unlock_cache(cache, err);
+ return err;
 /* Removes PAGE from the LRU list, removes all of its entries from
Received on 2011-04-02 07:53:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.