[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1079008 - /subversion/trunk/subversion/svnadmin/main.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 9 Mar 2011 11:06:09 -0500

On Tue, Mar 8, 2011 at 11:14, Stefan Sperling <stsp_at_elego.de> wrote:
>...
> Fair enough, but it should still be opt-in.
> We could add a config directive in ~/.subversion/config.
> If it turns out to be beneficial, users will enable it.
> However, since ra_local is used mostly for testing I don't expect this
> to be used much in practice. Our test suite might benefit.

I would like to just snip this suggestion in the bud right now.

Add options to the config file is *NASTY*. It completely disconnects
the operation of the command from the inputs to accomplish it.
Subversion has had a long history of distaste for environment
variables that alter its behavior. One user runs a command, and gets
something entirely different from another user with a different set of
environment variables. The config file is *exactly* the same sort of
monster. As a project, we avoided envvars so that posted recipes would
act the same for everybody using/reading them.

Now, maybe cache size is okay for the config since it doesn't affect
the operation, but... geez. Can we just stop inflating that file? So
much stuff gets hidden in there from the users' view.

"Wait.. HUH?! Why'd it do that?! ... oh, hell... stupid config
setting!! <forehead-slap>"

Cheers,
-g
Received on 2011-03-09 17:06:39 CET

This is an archived mail posted to the Subversion Dev mailing list.