[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Hyrum K Wright <hyrum_at_hyrumwright.org>
Date: Fri, 4 Mar 2011 09:34:17 -0600

On Thu, Mar 3, 2011 at 12:05 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> Greg Stein <gstein_at_gmail.com> writes:
>
>> It is a lot of crap just to avoid a single cast. It makes the code
>> more complicated than it needs to be.
>
> I don't see the cast as an improvement but I won't object if somebody
> changes it (a bit like one variable declaration per line which I think
> is crap :)
>
> I'll point out that this is application memory. áIf somebody were to
> inadvertently modify the code to write through the non-const pointer
> that would be a SEGV bug waiting for an application to pass read-only
> memory. áUnlikely, I know.

Reverted r1076645 and added the cast in r1078008.

-Hyrum
Received on 2011-03-04 16:34:50 CET

This is an archived mail posted to the Subversion Dev mailing list.