[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 03 Mar 2011 18:05:41 +0000

Greg Stein <gstein_at_gmail.com> writes:

> It is a lot of crap just to avoid a single cast. It makes the code
> more complicated than it needs to be.

I don't see the cast as an improvement but I won't object if somebody
changes it (a bit like one variable declaration per line which I think
is crap :)

I'll point out that this is application memory. If somebody were to
inadvertently modify the code to write through the non-const pointer
that would be a SEGV bug waiting for an application to pass read-only
memory. Unlikely, I know.

Received on 2011-03-03 19:06:17 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.