RE: [PATCH] Fix for issue 3799 - exporting file should not overwrite

> -----Original Message-----
> From: Julian Foad [mailto:julian.foad_at_wandisco.com]
> Sent: 25 February 2011 15:33
> To: Noorul Islam K M
> Cc: Subversion
> Subject: Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite
>
> On Sat, 2011-02-19, Noorul Islam K M wrote:
> > I think it is this way
> >
> > If specified target ('/tmp/iota' in the example above) is a ...
> > nothing -> fine
> > file -> if 'force' then overwrite else error
> > symlink -> if 'force' then overwrite else error
> > special -> if 'force' then overwrite else error
> > dir -> if sub-target ('/tmp/iota/iota') is a ...
> > nothing -> fine
> > file -> if 'force' then overwrite else error
> > symlink -> if 'force' then overwrite else error
> > special -> if 'force' then overwrite else error
> > dir -> error cannot force
>
> (That's all when the source is a file; a dir is handled differently.)
>
> OK, that looks good. I agree that that would be a good behaviour to
> implement.
>
My 2p:

Why would we want dirs to be handled differently? Surely, we want the behaviour to be "as expected" as possible, and if file export behaves differently to directory export... that's not so good.

Also, does this work as intended when using externals? I recall trying to export directories using externals to the same location on the filesystem and finding that each external wiped the target before copying the files (imagine you have several C modules and want to export all the headers from each of them to a single include directory, as an example of what I was trying to achieve).
Received on 2011-02-28 14:26:04 CET