Re: svn commit: r1073366 - in /subversion/trunk: notes/wc-ng/pristine-store subversion/libsvn_wc/wc-queries.sql subversion/libsvn_wc/wc_db_pristine.c

On Sat, 2011-02-26, Branko Čibej wrote:
> On 26.02.2011 20:40, Ivan Zhakov wrote:
> > Btw I think it makes sense rename file to tmp directory in working
> > copy instead of pristines directory, since it could be crash/failure
> > between rename and delete. In this case pristines directory will
> > polluted with orphaned pristines.
>
> That works as long as the pristine store lives in the WC root, so yes.

This seems to be a good plan. Thanks for the help. I'll do it right
away.

> BTW Julian, have you considered making the pristine files read-only
> (once they're written of course)? If yes, then be aware that in order to
> delete and/or rename a file on Windows, you have to first clear the
> read-only bit.

It seems sensible to make them read-only if it's near zero cost, and I
think it is. Our normal delete API svn_io_remove_file2() first clears
the read-only bit, although I've just noticed its doc string doesn't say
so. I'll update it.

- Julian
Received on 2011-02-28 13:28:07 CET