On 23.02.2011 11:52, John Szakmeister wrote:
> On Wed, Feb 23, 2011 at 3:43 AM, Stefan Fuhrmann
> <stefanfuhrmann_at_alice-dsl.de> wrote:
> [snip]
>> List of integration branches:
>> -----------------------------
>>
>> integrate-is-cachable
>> - replace the fixed 1MB limit to the cachable full-text
>> size in FSFS with a cache-specific implementation
> Took a look at this one. The changes look good. The only bit I
> didn't understand was this fragment:
>
> {{{
> +/* Store fulltext in RB in the fulltext cache used by said RB. Items that
> + * are too large to be cached won't. Also, this will be a no-op if no
> + * fulltext cache has been enabled in RB.
> + */
> static svn_error_t *
> rep_read_contents_close(void *baton)
> }}}
>
> I think that comment is probably misplaced. The only thing in there
> are two destroy functions. :-)
Thanks for the review! Docstring fixed in 1074082.
-- Stefan^2.
Received on 2011-02-24 10:20:06 CET