[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove dead code - was - Re: svn commit: r1067669

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Thu, 24 Feb 2011 09:39:21 +0100

On 23.02.2011 12:03, Stefan Sperling wrote:
> On Wed, Feb 23, 2011 at 09:05:16AM +0100, Stefan Fuhrmann wrote:
>> On 23.02.2011 06:47, Dongsheng Song wrote:
>>
>> Hi Donsheng,
>>
>> Thanks for your review. You are right that these two
>> functions are not being used right now, but the
>> integration-partial-getter and integration-is-cachable
>> branches will add them to the svn_cache_t interface.
>>
>> I didn't temporarily remove the functions from the
>> membuffer cache code to reduce the merge hazards
>> that I already get for merging changes from the
>> performance branch in a completely different order
>> and granularity then that in which they got developed.
> You could #if 0 them to get rid of the warnings,
> and explain the situation in a comment.
Done so in r1074072.

-- Stefan^2.
Received on 2011-02-24 09:40:16 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.