[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash during svn blame on windows 64-bit version

From: Branko Čibej <brane_at_e-reka.si>
Date: Thu, 24 Feb 2011 09:09:45 +0100

So is this a problem with the APR build, or with Subversion? It sure
looks like an APR issue to me.

On 24.02.2011 08:53, Marc Haesen wrote:
> Hi,
>
>
>
> I saw a crash when running svn blame with a svn.exe compiled for win64
> on trunk.
>
> After some investigation I found the reason for the crash.
>
>
>
> The reason is because apr.h is using the define WIN64 for defining the
> APR_SIZEOF_VOIDP define.
>
> (I am using the apr.h/apr.hw delivered with httpd-2.2.17)
>
>
>
> WIN64 is currently not defined when compiling for 64-bit on windows.
>
> This caused the wrong code to be generated for the contains_eol function
> in subversion\libsvn_diff\diff_file.c (revision 1074059)
>
>
>
> Two solutions:
>
>
>
> 1. Replace #ifdef WIN64 by #ifdef _WIN64 in apr.h (or apr.hw since
> this is actually the source)
> 2. Add the WIN64 to the compile options when compiling for 64-bit
> windows
>
>
>
> I used option 1 since _WIN64 is always defined by visual studio when
> compiling for 64-bit. This solved the crash.
>
>
>
> Regards,
>
> Marc
>
>
Received on 2011-02-24 09:10:27 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.