Stefan Sperling <stsp_at_elego.ed> writes:
> On Mon, Feb 21, 2011 at 03:58:00PM +0530, Noorul Islam K M wrote:
>
>> Stefan Sperling <stsp_at_elego.de> writes:
>> > But I think there is value in seeing the error message in the test code.
>> > It makes it much easier for those reading the test code to follow
>> > what kind of error the test is expecting. If all people can go by
>> > is the error code, then they'll have to keep looking up error codes
>> > to understand what the test is trying to do.
>> > I think that's worse than adjusting tests when the message changes
>> > every once in a while.
>>
>> Actually earlier there was request like this. So I thought it is ok to
>> have it here also. Please see r1071961.
>
> That has expected errors that only list error codes, yes.
> I would prefer a regex that contains at least part of the error message
> to make it more obvious what the error is about.
Then I think that revision can be reverted. Because that also contains
combining multiple tests which also you rejected.
Thanks and Regards
Noorul
Received on 2011-02-21 11:39:56 CET