[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 21 Feb 2011 11:35:23 +0100

On Mon, Feb 21, 2011 at 03:58:00PM +0530, Noorul Islam K M wrote:
> Stefan Sperling <stsp_at_elego.de> writes:
> > But I think there is value in seeing the error message in the test code.
> > It makes it much easier for those reading the test code to follow
> > what kind of error the test is expecting. If all people can go by
> > is the error code, then they'll have to keep looking up error codes
> > to understand what the test is trying to do.
> > I think that's worse than adjusting tests when the message changes
> > every once in a while.
> Actually earlier there was request like this. So I thought it is ok to
> have it here also. Please see r1071961.

That has expected errors that only list error codes, yes.
I would prefer a regex that contains at least part of the error message
to make it more obvious what the error is about.
Received on 2011-02-21 11:36:03 CET

This is an archived mail posted to the Subversion Dev mailing list.