[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1067380 [1/3] - in /subversion/trunk/subversion/tests/cmdline: ./ svntest/

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 07 Feb 2011 15:29:50 +0000

> I haven't tested it, but the Right solution feels like we should make
> the tests not call each other. Either they should be combined into
> one test, or the common code should be factored out into a helper
> method. What benefit does having the called test give, if the *exact*
> same code is being tested elsewhere?

I suppose they could be combined now. When originally written the first
test, a copy, passed but second test, the same copy followed by a
revert, failed. If I used just used one test then it would have been an
XFAIL and the working operation could have broken without triggering an
additional FAIL.

-- 
Philip
Received on 2011-02-07 16:30:33 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.