[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1064093-/subversion/trunk/subversion/libsvn_repos/authz.c

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Fri, 28 Jan 2011 00:39:57 +0530

>-----Original Message-----
>From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]
>Sent: Fri 1/28/2011 12:16 AM
>To: Kamesh Jayachandran; Arwin Arni Nandagopal
>Cc: dev_at_subversion.apache.org
>Subject: Re: svn commit: r1064093-/subversion/trunk/subversion/libsvn_repos/authz.c
 
>Kamesh Jayachandran wrote on Fri, Jan 28, 2011 at 00:14:35 +0530:
>>
>> >> It might be a rare situation,
>> >> but *if* folks have come to depend on the case-sensitivity of these checks,
>> >> they need to prepare for the fallout of this loosening of the policy.
>> >>
>>
>> >Sorry for not thinking about this earlier, but:
>> >Why was the fix to make all checks case-INsensitive, as opposed to
>> >making all checks case-sensitive?
>>
>> We use svn_config_read to parse the authz which always stores the section names in *lower* case in its internal hash table.
>>
>> See subversion/libsvn_subr/config.c:make_hash_key().
>>
>> We need to rev svn_config_read to accept bool case_sensitive_section_parser. Then we can change the behaviour to always case-sensitive approach as against today's case-insensitive approach.
>>

>Thanks for the reminder.

>Do you think it's a good idea?

>Personally I'm +0.5, since IMO we should be treating pathnames
>case-insensitively.

Same case with me.

With regards
Kamesh Jayachandran
Received on 2011-01-27 20:12:36 CET

This is an archived mail posted to the Subversion Dev mailing list.