[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1064093 -/subversion/trunk/subversion/libsvn_repos/authz.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 27 Jan 2011 20:46:15 +0200

Kamesh Jayachandran wrote on Fri, Jan 28, 2011 at 00:14:35 +0530:
>
> >> It might be a rare situation,
> >> but *if* folks have come to depend on the case-sensitivity of these checks,
> >> they need to prepare for the fallout of this loosening of the policy.
> >>
>
> >Sorry for not thinking about this earlier, but:
> >Why was the fix to make all checks case-INsensitive, as opposed to
> >making all checks case-sensitive?
>
> We use svn_config_read to parse the authz which always stores the section names in *lower* case in its internal hash table.
>
> See subversion/libsvn_subr/config.c:make_hash_key().
>
> We need to rev svn_config_read to accept bool case_sensitive_section_parser. Then we can change the behaviour to always case-sensitive approach as against today's case-insensitive approach.
>

Thanks for the reminder.

Do you think it's a good idea?

Personally I'm +0.5, since IMO we should be treating pathnames
case-insensitively.

Daniel

> With regards
> Kamesh Jayachandran
Received on 2011-01-27 19:50:46 CET

This is an archived mail posted to the Subversion Dev mailing list.