[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1054989 - /subversion/trunk/subversion/libsvn_client/locking_commands.c

From: Noorul Islam K M <noorul_at_collab.net>
Date: Tue, 04 Jan 2011 21:31:10 +0530

Philip Martin <philip.martin_at_wandisco.com> writes:

> jszakmeister_at_apache.org writes:
>
>> Author: jszakmeister
>> Date: Tue Jan 4 11:56:18 2011
>> New Revision: 1054989
>>
>> URL: http://svn.apache.org/viewvc?rev=1054989&view=rev
>> Log:
>> Fix syntax inconsistency and update comments.
>>
>> * libsvn_client/locking_commands.c
>> (organize_lock_targets): Fix syntax inconsistency by removing
>> unnecessary braces from 'if' block. Update comments to reflect new
>> function names used.
>>
>> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>>
>> Modified:
>> subversion/trunk/subversion/libsvn_client/locking_commands.c
>>
>> Modified: subversion/trunk/subversion/libsvn_client/locking_commands.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/locking_commands.c?rev=1054989&r1=1054988&r2=1054989&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_client/locking_commands.c (original)
>> +++ subversion/trunk/subversion/libsvn_client/locking_commands.c Tue Jan 4 11:56:18 2011
>> @@ -191,18 +191,15 @@ organize_lock_targets(const char **commo
>>
>> /* Get the common parent and all paths */
>> if (url_mode)
>> - {
>> SVN_ERR(svn_uri_condense_targets(common_parent_url, &rel_targets,
>> targets, TRUE, pool, pool));
>> - }
>> else
>> - {
>> SVN_ERR(svn_dirent_condense_targets(common_parent_url, &rel_targets,
>> targets, TRUE, pool, pool));
>> - }
>
> The remaining lines have the wrong indentation.

My mistake. I am not sure whether another patch is necessary for
this. I am attaching one which fixes the indentation problem.

Log
[[[

Fix wrong indentation caused by r1054989.

* subversion/libsvn_client/locking_commands.c
  (organize_lock_targets): Fix wrong indentation.

]]]

Thanks and Regards
Noorul

Index: subversion/libsvn_client/locking_commands.c
===================================================================
--- subversion/libsvn_client/locking_commands.c (revision 1055082)
+++ subversion/libsvn_client/locking_commands.c (working copy)
@@ -191,11 +191,11 @@
 
   /* Get the common parent and all paths */
   if (url_mode)
- SVN_ERR(svn_uri_condense_targets(common_parent_url, &rel_targets,
- targets, TRUE, pool, pool));
+ SVN_ERR(svn_uri_condense_targets(common_parent_url, &rel_targets,
+ targets, TRUE, pool, pool));
   else
- SVN_ERR(svn_dirent_condense_targets(common_parent_url, &rel_targets,
- targets, TRUE, pool, pool));
+ SVN_ERR(svn_dirent_condense_targets(common_parent_url, &rel_targets,
+ targets, TRUE, pool, pool));
 
   /* svn_uri_condense_targets and svn_dirent_condense_targets leaves
      URLs/paths empty if TARGETS only had 1 member, so we special case
Received on 2011-01-04 17:02:27 CET

This is an archived mail posted to the Subversion Dev mailing list.