[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove redundant member skip_descendants from libsvn_wc/update_editor.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 04 Jan 2011 15:49:11 +0000

Arwin Arni <arwin_at_collab.net> writes:

> In my pursuit to understand libsvn_wc/update_editor.c I came across an
> unnecessary member (skip_descendants) in the
> dir_baton. skip_descendants and skip_this are being set at the same
> time and have identical values at all times. I have removed one of
> these (skip_descendants) and the *relevant* code that I understand as
> being unreachable. I have attached the patch and a log message. Please
> review and respond.

This is one of the bits of code that needs some work for 1.7. In 1.6 we
generally skipped all the changes within a tree conflict, but in 1.7 we
can always make all the changes to the metadata; it's only changes to
the working tree that need to be skipped.

I'll take a look at your patch, it looks like a useful step.

Received on 2011-01-04 16:49:58 CET

This is an archived mail posted to the Subversion Dev mailing list.