Re: [Issue 3770] New - JavaHL method to set binary property is broken

On Thu, Dec 30, 2010 at 2:57 PM, Mark Phippard <markphip_at_gmail.com> wrote:
> On Thu, Dec 30, 2010 at 2:17 PM, Hyrum K Wright <hyrum_at_hyrumwright.org> wrote:
>
>> Mark,
>> Daniel pointed out on IRC that all the revpropTable arguments in the
>> JavaHL API are Map<String, String>.  Should they be adjusted to
>> Map<String, byte[]> ?
>
> What is the rule for revision properties?  I thought they had to be
> UTF-8 strings, in which case the Java String class seems more
> appropriate than using Byte[] which would imply the user can assign
> binary values to the property.  If Revision properties can contain
> binary values, then yes we should not be using String here.

I don't remember what the repository enforces, but the underlying API
contains a hash of const char * revprop names, with values of
svn_string_t *, which is our counted string which can contain
arbitrary binary data.

So the client API allows binary data, but it might be caught further
down the library stack.

-Hyrum
Received on 2010-12-30 21:03:41 CET