[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove redundant member - libsvn_wc/update_editor.c:file_baton.added_with_history

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Thu, 16 Dec 2010 14:14:09 +0530

On 12/15/2010 09:17 PM, Arwin Arni wrote:
> Hi,
> I was looking through the subversion/libsvn_wc/update_editor.c and
> noticed that there was a redundant member (added_with_history) in the
> file baton structure. This is not being set anywhere which results in
> some unreachable code. I have removed the member and the corresponding
> unreachable code. This was (as I gather from svn blame) introduced in
> r867451 by glasser to implement copy-on-update. I understand that some
> of this was reverted by cmpilato. I guess this should have been
> removed too. I have attached a patch and a log message. Please review
> and respond.
> Regards,
> Arwin Arni
Thanks Arwin.

Committed it in r1049819.

With regards
Kamesh Jayachandran
Received on 2010-12-16 09:48:57 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.