[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Remove redundant member - libsvn_wc/update_editor.c:file_baton.added_with_history

From: Arwin Arni <arwin_at_collab.net>
Date: Wed, 15 Dec 2010 21:17:57 +0530


I was looking through the subversion/libsvn_wc/update_editor.c and
noticed that there was a redundant member (added_with_history) in the
file baton structure. This is not being set anywhere which results in
some unreachable code. I have removed the member and the corresponding
unreachable code. This was (as I gather from svn blame) introduced in
r867451 by glasser to implement copy-on-update. I understand that some
of this was reverted by cmpilato. I guess this should have been removed
too. I have attached a patch and a log message. Please review and respond.

Arwin Arni

Received on 2010-12-15 17:18:46 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.