Random community nit: The attached log message seems to have little to
do with email subject of "Input validation observations". In the
future, when sending a new patch to the list, I'd recommend starting a
new thread, complete with it's own "[PATCH] ..." subject, as
recommended in the patch submission guidelines. It's more likely to
get noticed than when it's tacked onto the end of a largely-unrelated
40-message thread.
Anyway, thanks for the work, I just don't want it to get lost. :)
-Hyrum
On Mon, Dec 13, 2010 at 9:05 AM, noorul Islam. Kamal Malmiyoda
<noorul_at_collab.net> wrote:
> I am top posting since my mails are not getting through with my mail client.
> I am using web based client which lacks quoting feature.
>
> This is in response to
>
> * "svn mv ^/ ^/" -> "Cannot move path
> 'https:/svn.apache.org/repos/asf' into itself"; should not print the URL
> as if it's a local path.
>
> Attached is the patch which improves the error message. Also added missing
> test. All the tests pass with 'make check'.
>
> Log
>
> [[[
> Make 'svn move' display correct error message while moving any
> path/URL onto or into itself. Add missing test.
>
> * subversion/libsvn_client/copy.c
> (try_copy): Display error message based on source type,
> (repos_to_repos_copy): Remove redundant code.
>
> * subversion/tests/cmdline/copy_tests.py
> (move_wc_and_repo_dir_to_itself, test_list): New test
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>
> Thanks and Regards
> Noorul
>
> -----Original Message-----
> From: Julian Foad [mailto:julian.foad_at_wandisco.com]
> Sent: Tue 11/30/2010 5:18 PM
> To: Subversion Development; noorul Islam. Kamal Malmiyoda
> Subject: Input validation observations
>
> I tried some potentially invalid inputs to "svn" a week or two ago and
> made notes on what I found. Just posting here in case anyone wants to
> do something about one or more of them.
>
> Noorul, I'm including you in the "To" addresses because you said you
> were looking for more small tasks to do, so feel free to pick one of
> these if you want to.
>
> Where I end with a question mark, it means I'm not sure if we want this
> change, it's just a suggestion.
>
> * "svn checkout ^/ ^/y" -> "A asf/cxf, A asf/cxf/utils, ...". (Don't
> try this without being ready on the Ctrl-C or Ctrl-\!) It seems to
> ignore "^/y" and create ./(basename(^/)); should fail: "'^/y' is not a
> WC path".
>
> * "svn checkout ^/subversion/trunk/build ^/y" -> "Checked out revision
> 1040465. URL 'https://svn.apache.org/repos/asf/y' doesn't exist".
> Bleach - that's just crazy. Should fail: "'^/y' is not a WC path".
>
> * "svn copy a ^/b c" doesn't detect the mixed source types in cl, only
> in lib; should reject them at CLI level?
>
> * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found
> in revision REV"?
>
> * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
> mix URL and local targets"?
>
> * "svn mkdir a ^/" -> "Can't create directory
> 'https:/svn.apache.org/repos/asf'"; should not print the URL as if it's
> a local path.
>
> * "svn mv ^/ ^/" -> "Cannot move path
> 'https:/svn.apache.org/repos/asf' into itself"; should not print the URL
> as if it's a local path.
>
> * "svn update ^/a" -> "Skipped
> 'https://svn.apache.org/repos/asf/a' ..."; should fail: "'^/a' is not a
> WC path"?
>
>
> - Julian
>
>
>
>
>
>
Received on 2010-12-13 16:19:40 CET