[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Please review : repositories recursive finding with SVNParentPath

From: David Burley <burley_at_geek.net>
Date: Wed, 8 Dec 2010 17:03:06 -0500


So I have forward-ported Stephane's patch to add recursion to SVNParentPath
for 1.6.15 (see attached patch). I have also started, but had to stop, work
on making it function with trunk (see also, attached patch). The 1.6.15
patch works, the trunk patch does not (some functions take different
arguments now, it seems -- and that may be part of it since I excised those
bits entirely). Anyways, I am hoping at minimum that this will allow the
patch to be used by someone else who needs this functionality. Ideally
someone with some better knowledge of the SVN coding standards and internals
would finish this for us and include it into the base distribution when they
have time. If I have or am given such time in the future, I will do that --
but the time isn't now unfortunately.

As for Glasser's prior concern that this would change the functionality and
potentially cause some security issues -- my response would be to add it to
a new devel line and note it as a functional change. I don't think there's
much use or safety in storing the repository in a deeper dir of something
that is apache accessible anyways -- so this would effectively make things
function more like I think should be expected anyways. I am going to also
attach these patches to the bug below.


David Burley
Systems Programmer/Analyst, Geeknet, Inc.

References to others with same request:

Original Email:
Received on 2010-12-08 23:08:19 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.