Re: svn commit: r1040832 - Port a fix for a FSFS packing race

Julian Foad wrote on Wed, Dec 08, 2010 at 13:30:42 +0000:
> I (Julian Foad) wrote:
> [...]
> > Studying the FSFS source code for the issues raised in this thread has
> > given me confidence that it seems to be doing the right thing, in
> > practice, at the moment.
> >
> > In 1043360 I added some comments about how to remove one source of
> > fragility in using the cached value. Again I'll say this looks
> > perfectly correct in its current usage.
> >

Agreed, the current uses of get_root_changes_offset() will always use
the same ffd->min_unpacked_rev as open_pack_or_rev_file() used.

> > I'll go ahead and apply the remove-retry-logic-from-path-rev-absolute
> > patch now.
>
> Committed revision 1043408.
>

Thank you!

(for not letting the length of this thread bury the patch)

> - Julian
>
>
Received on 2010-12-08 23:02:06 CET