[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] copy_tests.py - expand move_file_back_and_forth, to verify issue #3429

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 08 Dec 2010 14:17:04 +0000

On Wed, 2010-11-17, Johan Corveleyn wrote:
> On Wed, Nov 17, 2010 at 2:14 AM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:
> > The attached patch expands the test "move_file_back_and_forth"
> > (copy_tests.py 45) as a regression test for issue#3429.
[...]
> I just realized that I can add a similar check to
> move_dir_back_and_forth. Here is a second patch that expands both
> tests.

Thank you, Johan. Committed revision 1043427. (I tweaked the comments
a bit.)

I have closed issue #3429.

> (note: can the "if svntest.main.wc_is_singledb(wc_dir)" be dropped
> from move_dir_back_and_forth?)

Because single-db is now always enabled? Yes. But it's sometimes nice
to be able to go back and test older code with the current tests, so
let's not hurry to remove it.

- Julian

> Log message:
> [[[
> Expand move_file_back_and_forth and move_dir_back_and_forth tests to verify
> issue #3429 ("svn mv A B; svn mv B A" generates replace without history).
>
> * subversion/tests/cmdline/copy_tests.py
> (move_file_back_and_forth): Check expected status before commit.
> (move_dir_back_and_forth): Check expected status after executing the moves.
> ]]]
Received on 2010-12-08 15:17:45 CET

This is an archived mail posted to the Subversion Dev mailing list.