Noorul Islam K M wrote:
> Ran test suite and found some failures and fixed them. All of them were
> passing URL to 'svn up' which is not at all required. Now all tests are
> passing with the below attached patch.
Thanks, Noorul. That's lovely. Committed revision 1043409.
- Julian
> Log
> [[[
>
> Make 'svn update' verify that URLs are not passed as targets.
>
> * subversion/svn/update-cmd.c,
> subversion/libsvn_client/update.c:
> (svn_cl__update, svn_client_update4): Raise an error if a URL was
> passed. Remove code that notifies 'Skipped' message for URL targets.
>
> * subversion/tests/cmdline/input_validation_tests.py
> (invalid_update_targets, test_list): New test
>
> * subversion/tests/cmdline/externals_tests.py,
> subversion/tests/cmdline/svntest/actions.py,
> (cannot_move_or_remove_file_externals,
> can_place_file_external_into_dir_external,
> external_into_path_with_spaces,
> inject_conflict_into_wc): Remove URL target from 'svn up' command.
>
> * subversion/tests/cmdline/basic_tests.py
> (basic_update): URLs are no longer accepted as targets. Remove test
> case for 'Skipped' message.
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
Received on 2010-12-08 14:33:28 CET