Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 2)
From: Danny Trebbien <dtrebbien_at_gmail.com>
Date: Sat, 27 Nov 2010 09:46:34 -0800
> I hope you aren't discouraged from working on the patch.
> To the point, I originally asked if your changes affected the performance
I don't have benchmarks, but it does not seem that the performance of
Note that when EOL_TRANSLATED is NULL, the overhead is a single NULL
> If the latter, then I apologize (to Daniel) for your having spent time
It's not a big deal, and I think that it helped me to understand the
This other idea is based on knowledge that b->repair is usually FALSE.
if ((! b->repair) && DIFFERENT_EOL_STRINGS(src_format,
The `DIFFERENT_EOL_STRINGS` check will run whenever b->repair is
The upside is that unnecessary NULL checks of TRANSLATED_EOL are
The downsides are:
1.) Another assumption must be made (namely, that the EOL_STR string
2.) It complicates the logic.
3.) This penalizes repair translations.
> > p.s. To avoid confusion, you can call me Danny if you would like. ¬†I
You piqued my curiosity. Here is a frequency table of first names of
That's a lot of Daniels.
This is an archived mail posted to the Subversion Dev mailing list.