[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: test failure 1.6.14 (svnsync test 29 with bdb; copyfrom)

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 18 Nov 2010 02:49:14 +0200

Stefan Sperling wrote on Thu, Nov 18, 2010 at 00:54:42 +0100:
> With BDB, svnsync crashes as follows during during svnsync test 29.
> It only happens with BDB. Running "./svnsync_tests.py 29 --fs-type=bdb"
> triggers the problem for me on the 1.6.x branch, too.
>
> I guess this could be related to this backport item:
> * improve svnsync handling of dir copies (r962377, -8)
>

You're being polite --- this backport item added the assert. :-)

> Details follow:
>
> SVNProcessTerminatedBySignal
> FAIL: svnsync_tests.py 29: descending into replaced dir looks in src
...
> #4 0x0000000201c7490a in add_subdir (source_root=0x20dbb60a0,
> target_root=0x2013790a0, editor=0x20aa28868, edit_baton=0x20aa288e8,
> path=0x2090df2a1 "trunk/H", parent_baton=0x20a8a90a0,
> source_path=0x2075150d0 "/trunk/A", authz_read_func=0,
> authz_read_baton=0x0, changed_paths=0x20aa28968, pool=0x207515028,
> dir_baton=0x7f7ffffec3b8) at subversion/libsvn_repos/replay.c:224
> 224 SVN_ERR_ASSERT(change->copyfrom_known);

FWIW, the code reads:
226 else if (change->change_kind == svn_fs_path_change_replace)
227 {
228 /* ### Can this assert fail? */
229 SVN_ERR_ASSERT(change->copyfrom_known);
230 copyfrom_path = change->copyfrom_path;
231 copyfrom_rev = change->copyfrom_rev;
232 }

So, yeah, I should have believed that API doc string which said the
copyfrom might not be known :P.

I wrote this, so I'll be happy to help investigating/fix the failures.

Daniel
Received on 2010-11-18 01:52:26 CET

This is an archived mail posted to the Subversion Dev mailing list.