Hi Philip,
Thanks for the review.
Philip Martin wrote:
>> +
>> + if (socket_name != NULL)
>> + {
>> + addr.sun_family = AF_UNIX;
>> + strncpy(addr.sun_path, socket_name, 108);
>> + sd = socket(AF_UNIX, SOCK_STREAM, 0);
>> + if (sd == -1)
>> + return FALSE;
>> +
>> + if (connect(sd, (struct sockaddr *)&addr, sizeof(addr)) == -1)
>> + {
>> + close(sd);
>> + return FALSE;
>> + }
>> + }
>> + else
>> + return FALSE;
>
> Use APR's socket interface?
Will explore this. I was thinking to use the assuan library (libassuan) which I
ve reserved for future.
>> Added: subversion/branches/gpg-agent-password-store/subversion/libsvn_auth_gpg_agent/version.c
>> URL: http://svn.apache.org/viewvc/subversion/branches/gpg-agent-password-store/subversion/libsvn_auth_gpg_agent/version.c?rev=1005065&view=auto
>> ==============================================================================
>> --- subversion/branches/gpg-agent-password-store/subversion/libsvn_auth_gpg_agent/version.c (added)
>> +++ subversion/branches/gpg-agent-password-store/subversion/libsvn_auth_gpg_agent/version.c Wed Oct 6 14:41:35 2010
>> @@ -0,0 +1,30 @@
>> +/*
>> + * version.c: libsvn_auth_gpg_agent version number
>> + *
>> + * ====================================================================
>> + * Copyright (c) 2008 CollabNet. All rights reserved.
>> + *
>> + * This software is licensed as described in the file COPYING, which
>> + * you should have received as part of this distribution. The terms
>> + * are also available at http://subversion.tigris.org/license-1.html.
>> + * If newer versions of this license are posted there, you may use a
>> + * newer version instead, at your option.
>> + *
>> + * This software consists of voluntary contributions made by many
>> + * individuals. For exact contribution history, see the revision
>> + * history and logs, available at http://subversion.tigris.org/.
>> + * ====================================================================
>> + */
>
> That's the wrong file header.
I ve made this change in r1005770. Will complete the other things which you
have pointed out in a separate commit.
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
Received on 2010-10-08 12:51:37 CEST