Re: svn commit: r1005065 - in /subversion/branches/gpg-agent-password-store: ./ build/generator/ subversion/include/ subversion/include/private/ subversion/libsvn_auth_gpg_agent/ subversion/libsvn_subr/

Hi Stefan,

Stefan Sperling wrote:
> On Wed, Oct 06, 2010 at 02:41:35PM -0000, stylesen_at_apache.org wrote:
>> Author: stylesen
>> Date: Wed Oct 6 14:41:35 2010
>> New Revision: 1005065
>>
>> URL: http://svn.apache.org/viewvc?rev=1005065&view=rev
>> Log:
>> On the 'gpg-agent-password-store' branch:
>>
>> Add GPG-AGENT support for Subversion password caching.
>
>
> Hi Senthil,
>
> some review inline below.

Thanks for the review. Made the necessary changes in r1005764.

>> + /* Create the CACHE_ID which will be generated based on REALMSTRING similar
>> + to other password caching mechanisms. */
>> + digest = svn_checksum_create(svn_checksum_md5, pool);
>> + svn_checksum(&digest, svn_checksum_md5, realmstring, strlen(realmstring),
>> + pool);
>
> Maybe use SHA1 instead?

I didn't make this change because the filename inside 'svn.simple' matches with
the 'CACHE_ID' now. I want the users to have some easy way to map it with their
realmstring, since we already use MD5 for this purpose I do not want to
introduce a variant using SHA1 which may confuse the users.

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/