[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r999507 - in /subversion/trunk/subversion: svnrdump/dump_editor.c tests/cmdline/svnrdump_tests.py

From: Ramkumar Ramachandra <artagnon_at_gmail.com>
Date: Thu, 23 Sep 2010 01:24:30 +0530

Hi again,

Ramkumar Ramachandra writes:
> > I think you've got your pointers confused. Can you drop the pstrdup(),
> > see that nothing breaks, and then we can discuss why nothing broke?
>
> Hehe, I wouldn't be surprised if this is the case -- I've been working
> with APR pools day and night now :p
>
> Okay, I'll drop this during the cleanup. Do explain this to me though :)

Just to be clear: I know that nothing will break. Memory for the
string "/" will be allocated statically by the compiler- its lifetime
is therefore the lifetime of the program, and it cannot be freed
before that. I made this change merely for the purpose of elegance-
except in this case, abspath always points to a dynamically allocated
memory location owned by a `pool` that can be freed. So I thought: why
not make make it always point to a dynamically allocated memory
location?

Does that make sense or am I just being silly? :p

-- Ram
Received on 2010-09-22 21:56:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.