Re: svn commit: r999507 - in /subversion/trunk/subversion: svnrdump/dump_editor.c tests/cmdline/svnrdump_tests.py

Hi Daniel,

Daniel Shahaf writes:
> It actually makes sense: "either there is a parent baton, or I'm
> creating the root baton (and therefore the caller passed path=NULL)".
>
> Choosing path=NULL to represent "the root" seems odd to me (that's not
> how we usually represent it), but that's for another day.

Ah. I guess that explains it was there in the first place :p

I think I'm using "" to represent the root somewhere, but I'll have to
check this. I'll figure something out during the cleanup.

> > True. However, abspath is a `char *` with no memory allocated to it: I
> > want whatever its value is to be allocated in `pool` since it's passed
> > around.
>
> I think you've got your pointers confused. Can you drop the pstrdup(),
> see that nothing breaks, and then we can discuss why nothing broke?

Hehe, I wouldn't be surprised if this is the case -- I've been working
with APR pools day and night now :p

Okay, I'll drop this during the cleanup. Do explain this to me though :)

-- Ram
Received on 2010-09-22 21:44:53 CEST