[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC/PATCH] Create a fresh svn_repos_parse_fns3_t

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Mon, 23 Aug 2010 13:44:06 +0100

On Thu, 2010-08-19 at 10:25 +0300, Daniel Shahaf wrote:
> Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 11:12:14 +0530:
> > Hi,
> >
> > I sent a patch a while ago for svn_repos_parse_dumpstream3. While I
> > wait for approval, this is an RFC patch describing my future plan once
> > that patch gets approved. It can be described tersely as "While at it
> > (adding the new callback), fix everything that's wrong with the
> > struct".

I have just read through Daniel's diff of this patch, and the change
appears to be:

  Add a dumpstream_version_record() method.
  Add scratch pool arguments to all methods.

Is that what you intended? If so, it sounds sane to me. (I would name
the scratch pool arguments 'scratch_pool'.)

- Julian
Received on 2010-08-23 14:44:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.