[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r981905 - /subversion/trunk/subversion/tests/cmdline/depth_tests.py

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 04 Aug 2010 11:58:54 +0100

Greg Stein <gstein_at_gmail.com> writes:

> On Tue, Aug 3, 2010 at 13:41, Julian Foad <julian.foad_at_wandisco.com> wrote:
>> Greg Stein wrote:
>>> Why would this be true only in single-db? Shouldn't the test perform
>>> exactly the same in both cases? I see no rationale for WHY these
>>> should differ.
>>>
>>> On Tue, Aug 3, 2010 at 10:56,  <philip_at_apache.org> wrote:
>>> > Make depth_tests.py 37-40 pass in single-db.
>>> >
>>> > * subversion/tests/cmdline/switc_tests.py
>>> >  (make_depth_tree_conflicts): Tweak expectations for single-db.
>> [...]
>>> >   expected_disk.remove('A/mu',
>>> >                        'A/B', 'A/B/lambda', 'A/B/E/alpha', 'A/B/E/beta',
>>> >                        'A/D/gamma');
>>> > +  if svntest.main.wc_is_singledb(sbox.wc_dir):
>>> > +    expected_disk.remove('A/B/E', 'A/B/F')
>>
>> It's just because in single-db mode, deleted dirs really go away from
>> disk, isn't it?

Yes. I thought this was a well known feature of wc-ng single-db.

>
> Beats me. Where is the comment to that effect? Where is the
> explanation in the log message?
>
> Why are these tests allowing *variant* outputs without any explanation?

I'm not sure how much explanation of wc-ng, single-db you expect in
the log message. Generally I try to avoid having the log message
simply repeat the code change. The code change already shows that
it's removing a directory from the expected_disk, I suppose the log
message could mention that it's a delete operation?

Or do you expect the test to continue to record these directories as
present but have some other part of the testsuite code ignore them?

-- 
Philip
Received on 2010-08-04 12:59:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.