[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r982173 - /subversion/trunk/subversion/svn/log-cmd.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 4 Aug 2010 12:40:22 +0200

On Wed, Aug 04, 2010 at 09:21:16AM -0000, rhuijben_at_apache.org wrote:
> Author: rhuijben
> Date: Wed Aug 4 09:21:13 2010
> New Revision: 982173
>
> URL: http://svn.apache.org/viewvc?rev=982173&view=rev
> Log:
> * subversion/svn/log-cmd.c
> (svn_cl__log): Check for paths starting with a '/' instead of using
> svn_dirent_is_absolute() as a '/a' style path is not absolute on
> Windows and OS/2, and some valid relpaths theoretically might be.

Thanks for fixing this.

>
> Modified:
> subversion/trunk/subversion/svn/log-cmd.c
>
> Modified: subversion/trunk/subversion/svn/log-cmd.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/log-cmd.c?rev=982173&r1=982172&r2=982173&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svn/log-cmd.c (original)
> +++ subversion/trunk/subversion/svn/log-cmd.c Wed Aug 4 09:21:13 2010
> @@ -648,7 +648,7 @@ svn_cl__log(apr_getopt_t *os,
> {
> target = APR_ARRAY_IDX(targets, i, const char *);
>
> - if (svn_path_is_url(target) || svn_dirent_is_absolute(target))
> + if (svn_path_is_url(target) || target[0] == '/')
> return svn_error_return(svn_error_createf(
> SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
> _("Only relative paths can be specified"
>
Received on 2010-08-04 12:42:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.