[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 28 Jun 2010 21:59:11 +0300 (Jerusalem Daylight Time)

Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -0000:
> On Mon, Jun 28, 2010 at 14:33, <rhuijben_at_apache.org> wrote:
> > Author: rhuijben
> > Date: Mon Jun 28 18:33:05 2010
> > New Revision: 958671
> >
> > URL: http://svn.apache.org/viewvc?rev=958671&view=rev
> > Log:
> > * subversion/libsvn_wc/adm_ops.c
> >  (svn_wc_add4): Fix indentation and remove a few more unneeded ifs.
>
> Argh!!!
>
> How am I supposed to review this? I can't tell what is indentation,
> versus actual code change.
>

svn diff -x-w ?

(on s.c.n viewvc's diffs used to ignore whitespace... doesn't seem to be
the case on s.a.o though)

> Please, please, please only do big whitespace change. Or functional
> change. Mixing them makes it unreviewable :-(
>

+1

> >...
>
> -g
>
Received on 2010-06-28 20:59:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.