[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r957094 - in /subversion/trunk: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_fs*/ subversion/libsvn_ra*/ ...

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 24 Jun 2010 19:35:21 +0300 (Jerusalem Daylight Time)

C. Michael Pilato wrote on Wed, 23 Jun 2010 at 22:43 -0000:
> Daniel Shahaf wrote:
> >> - SVN_ERR(svn_ra_svn_write_cmd(conn, pool, "get-locks", "c", path));
> >> + /* Figure out the repository abspath from PATH. */
> >> + abs_path = svn_path_url_add_component2(sess->url, path, pool);
> >> + SVN_ERR(svn_ra_get_path_relative_to_root(session, &abs_path,
> >> + abs_path, pool));
> >
> > I think this change means that, in build.conf, libsvn_ra should have
> > been added as a dependency to [libsvn_ra_svn]. (This patch added it only
> > to [svnserve].)
> >
> > Unless objections, I'll make this change (while also committing the
> > ra_svn protocol bits noted on IRC and in the issue).
>
> Fine with me. (The change I made was sufficient to fix the problem I was
> seeing in my build.)
>

Looking further, the patch added svn_ra_get_path_relative_to_root() to
all network-based RA layers. However, when I try to add libsvn_ra in
build.conf as suggested above, I just get errors from configure/make
about circular dependencies :-(

I'm not sure what's going on here. But if it breaks in the future,
hopefully this thread is going to be useful...
Received on 2010-06-24 18:35:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.