[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ruby bindings don't work with 1.9 + patch

From: Joe Rozner <joe_at_deadbytes.net>
Date: Wed, 23 Jun 2010 10:52:50 -0700

Sorry about that, here is the patch file again as a .txt file.

Joe Rozner

diff -Naur subversion-1.6.12-orig/subversion/bindings/swig/ruby/svn/core.rb subversion-1.6.12/subversion/bindings/swig/ruby/svn/core.rb
--- subversion-1.6.12-orig/subversion/bindings/swig/ruby/svn/core.rb 2010-06-22 20:18:01.000000000 -0700
+++ subversion-1.6.12/subversion/bindings/swig/ruby/svn/core.rb 2010-06-22 20:18:47.000000000 -0700
@@ -644,16 +644,16 @@
 
       def infinity_or_empty_from_recurse(depth_or_recurse)
         case depth_or_recurse
- when true : DEPTH_INFINITY
- when false : DEPTH_EMPTY
+ when true then DEPTH_INFINITY
+ when false then DEPTH_EMPTY
           else depth_or_recurse
         end
       end
 
       def infinity_or_immediates_from_recurse(depth_or_recurse)
         case depth_or_recurse
- when true : DEPTH_INFINITY
- when false : DEPTH_IMMEDIATES
+ when true then DEPTH_INFINITY
+ when false then DEPTH_IMMEDIATES
           else depth_or_recurse
         end
       end

On Jun 23, 2010, at 12:25 AM, Bert Huijben wrote:

>> -----Original Message-----
>> From: Joe Rozner [mailto:joe_at_deadbytes.net]
>> Sent: woensdag 23 juni 2010 5:43
>> To: dev_at_subversion.apache.org
>> Subject: Ruby bindings don't work with 1.9 + patch
>>
>> The ruby bindings were having issues being used with Ruby 1.9 due to
>> changes in the case syntax. Here is a patch file that fixes the issue.
>>
>> Joe Rozner
>> joe_at_deadbytes.net
>
> Hi Joe,
>
> Your patch didn't reach the list. Can you try resending your patch?
> (Possibly with a .txt extension)
>
> I can't check your patch now to check if it has one, but adding a log
> message to your patch (either in the patch file or in the mail) makes
> reviewing much easier.
>
> Thanks,
> Bert
>
Received on 2010-06-23 19:53:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.