[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r920424 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_wc/lock.c libsvn_wc/util.c libsvn_wc/wc.h

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 2 Jun 2010 20:00:20 -0400

On Wed, Jun 2, 2010 at 17:56, Bert Huijben <bert_at_vmoo.com> wrote:
>
>
>> -----Original Message-----
>> From: Philip Martin [mailto:philip.martin_at_wandisco.com]
>> Sent: woensdag 2 juni 2010 23:45
>> To: dev_at_subversion.apache.org
>> Subject: Re: svn commit: r920424 - in /subversion/trunk/subversion:
>> include/private/svn_wc_private.h libsvn_wc/lock.c libsvn_wc/util.c
>> libsvn_wc/wc.h
>>
>> Paul Burba <ptburba_at_gmail.com> writes:
>>
>> > This implies that a disjoint child is equivalent to a switched child,
>> > but despite child_is_disjoint's lack of documentation, it seems clear
>> > that a child can be disjoint but not switched.  Am I missing something
>> > here?
>>
>> I think you are correct.  Perhaps child_is_disjoint could set a switched
> flag as
>> well as a disjoint flag?  SVN_ERR_WC_NOT_DIRECTORY is deprecated, it
>> should be changed to SVN_ERR_WC_NOT_WORKING_COPY.
>
> I think we have some _wc_is_root function that performs all these checks,
> but (without looking at the code) I'm not sure if it correctly checks all
> kinds of sub working copy obstructions I described in my previous mail
> correctly.

update_editor.c::svn_wc__check_wc_root()

Cheers,
-g
Received on 2010-06-03 02:01:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.