[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

From: Uwe Stuehler <subversion-lists_at_bsdx.de>
Date: Tue, 27 Apr 2010 01:02:15 +0200

On 04/26/10 05:27 PM, C. Michael Pilato wrote:
> Hyrum K. Wright wrote:
>>
>> On Fri, Apr 23, 2010 at 4:24 PM, Stefan Sperling<stsp_at_elego.de
[...]
>> I think it's best to consistently expand "^/". In my mind the above
>> should be interpreted as:
>> $ svn add http://svn.example.com/repos/
>>
>> which would then generate whatever warning it should.
>>
>> The shell doesn't selectively expand wildcards and such depending on the
>> Subversion command; selective expanding our own syntactic shortcuts
>> would just lead to more confusion.
>
> I agree. But I want to keep Uwe on task as much as possible.
>
> Uwe, if you're still willing to work on this, could you submit a patch for
> svn_client_add4(), svn_client_status5(), and any other of the svn-client API
> functions that cannot accept URL inputs which does the svn_path_is_url()
> test and, if true, returns the appropriate error code?
>
> We can take up the matter of inconsistent relative URL expansion separately.
>
Yes, certainly. I may not be able to respond as fast as I would like,
but I can do that nevertheless.

Many many thanks for the review - I'll send another patch soon(ish). :)
Uwe
Received on 2010-04-27 01:03:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.