[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 26 Apr 2010 11:27:02 -0400

Hyrum K. Wright wrote:
>
> On Fri, Apr 23, 2010 at 4:24 PM, Stefan Sperling <stsp_at_elego.de
> <mailto:stsp_at_elego.de>> wrote:
>
> ...
>
> We should also consider changing the way "^/" is interpreted.
> Maybe only commands that expect URLs as arguments should expand "^/"
> to a URL? That way the above error would become:
>
> $ svn add ^/
> svn: warning: '/path/to/working/copy/^' not found
>
>
> I think it's best to consistently expand "^/". In my mind the above
> should be interpreted as:
> $ svn add http://svn.example.com/repos/
>
> which would then generate whatever warning it should.
>
> The shell doesn't selectively expand wildcards and such depending on the
> Subversion command; selective expanding our own syntactic shortcuts
> would just lead to more confusion.

I agree. But I want to keep Uwe on task as much as possible.

Uwe, if you're still willing to work on this, could you submit a patch for
svn_client_add4(), svn_client_status5(), and any other of the svn-client API
functions that cannot accept URL inputs which does the svn_path_is_url()
test and, if true, returns the appropriate error code?

We can take up the matter of inconsistent relative URL expansion separately.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-04-26 17:27:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.