[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 3596] 'hotcopy' of packed fsfs repos may corrupt target revprops.db

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 16 Apr 2010 00:52:25 +0300 (Jerusalem Daylight Time)

Daniel Shahaf wrote on Wed, 14 Apr 2010 at 23:52 +0300:
> Philip Martin wrote on Wed, 14 Apr 2010 at 12:17 +0100:
> > -svn_error_t *
> > -svn_fs_fs__open_rep_cache(svn_fs_t *fs,
> > - apr_pool_t *pool)
> > {
> > - /* Be idempotent. */
> > + /* Be idempotent. ### This is not thread safe. */
> > if (ffd->rep_cache_db)
> > return SVN_NO_ERROR;
> >
>
> I suppose we could fix the thread-unsafety while we're here. Something like this?
>
> [[[
> In FSFS, open the FS object's rep-cache atomically. Extend fs_fs_data_t
> and svn_atomic__init_once() to support this.

Committed in r934599 and r934603, and nominated for backport along with
the #3506 revisions introducing the bug.

Daniel
(probably need some coffee)
Received on 2010-04-15 23:52:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.